Home›1939 songs›When You're Smiling🌐EnglishEnglishDeutschEspañolFrançaisItalianoNederlandsPolskiPortuguêsSvenskaTürkçe日本語EntityQ7992841· pop 5· linked from 190 articlesWhen You're Smilingoriginal song composed by Larry Shay, lyrics by Mark Fisher and Joe GoodwinAvailable in 4 languagesFrançaisDeutsch日本語via Wikidata sitelinks · CC0ConnectionssongEntityLouis ArmstrongEntityCategories1939 songsAssociation football songs and chantsLouis Armstrong songsPop standardsSongs with music by Larry ShaySongs written by Mark Fisher (songwriter)